search

pharmaverse / admiral.test

Test SDTM data for use with admiral
Other
2 stars 1 forks source link

Add variables to mh for admiral template script and dataset #51

Closed bms63 closed 2 years ago

bms63 commented 2 years ago

To make admiral_admh dataset and template script more interesting and complex within the admiralpackage we need to add variables to the sdtm dataset mh.

At the moment we need the following variables could be added: MHOCCUR MHENDTC MHENRF MHENTPT

bms63 commented 2 years ago

@yangc71

rossfarrugia commented 2 years ago

If useful see how we did similar for DS here in this PR: https://github.com/pharmaverse/admiral.test/pull/36

yangc71 commented 2 years ago

@rossfarrugia / @bms63 I was trying to work on this but I couldn't create a branch, could you please grant me write access to admiral.test? Thanks.

rossfarrugia commented 2 years ago

@yangc71 now granted, and check out this PR https://github.com/pharmaverse/admiral.test/pull/55 for the new guidance on how to go about making this update.

gg106046 commented 2 years ago

The variables 'MHSTAT' and 'MHENRF' will have to be added to MH as well.

rossfarrugia commented 2 years ago

@yangc71 are you ok to add these and make another PR?

yangc71 commented 2 years ago

Thanks @rossfarrugia I added the two variables in MH. @gg106046 / @bms63 I haven't used those variables before, and I understand we are adding them to help derive the GSK AHIST variable downstream. Could you please help review to see if I added the variables properly? Thanks!