pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
224 stars 63 forks source link

General Issue: Questions about validation #1887

Closed seth127 closed 1 year ago

seth127 commented 1 year ago

Background Information

This may work better in the "Discussions" section, but I wasn't sure how to start one of those...

Hello Admiral team, First off, fantastic work here! I really appreciate how well done this package is, and the same for the entire pharmaverse. And, to the extent any of you are involved with the R Validation Hub, I really appreciate that work as well. Which brings me to my question...

I lead the Data Science team at Metrum Research Group. One of our main projects is working on a suite of open source R packages, primarily used for Pharmacometrics. Here is a link to some of our work, if you're interested.

We are continuing to work on how to most comprehensively and most efficiently Validate these packages, for our own use and for the use of others. I know your team has also put a lot of thought and work into this and I'm interested to hear about how you are currently approaching it.

We have found much of the R Validation Hub work very valuable, and we are already using many of their principles and several of their packages. That said, the majority of their work seems focused on validating packages developed externally for their own use in their respective companies. While this work has been very helpful to us (obviously, we use many packages developed by the open source community), I am particularly looking for guidance on what validation you do for the packages you are developing internally. In particular, how is it different than the validation you do for something like the tidyverse packages?

I see several mentions of validation in your documentation, in particular this FAQ. But again, this is focused on what another company might do if they are interested in using admiral. Is this essentially the same thing you are doing internally? Statements like this one make me think that your internal processes are focused more on traditional software development and testing best practices, and that Validation portion is left to the "user". I recognize that in many cases, the "user" is also yourselves, just in a different role. This pattern makes sense and seems appealing to me, but I want to make sure that I'm not misunderstanding or assuming too much.

Thanks in advance for any help or guidance. And of course, I realize that you may not be able or willing to discuss these kinds of internal processes, especially in a public forum like this. Please let me know if there is a more appropriate place for this conversation, or if any of you are willing to connect directly. And thanks again for all of your hard work to promote open source software.

Best, Seth Green

Definition of Done

A lively discussion on validating open source software development.

bms63 commented 1 year ago

Hey @seth127 this is a great post for the pharmaverse slack. Are you on that slack channel?

My feeling is that most companies are willing to share their validation processes for open source products. As it helps to push that ball further for industry and health authority acceptance. At GSK we evaluate each package used for Clinical reporting looking at such details as testing, dependencies, author(s) involvement with that work, documentation and industry acceptance. I believe this was a talk at US Phuse.

Anyways,...please post this on slack as a lot more people are on there from all over Pharma

rossfarrugia commented 1 year ago

Agree Ben! There's even a validation channel there as it's always such a hot topic in the open source space. Will close this issue in anticipation of the discussion moving to Slack.

As FYI @seth127 here's some R/Pharma past sharing to help answer your question from Roche/Genentech perspective: https://www.youtube.com/watch?v=xksxuvXVimM https://www.youtube.com/watch?v=ZfZpypQ1jSM