Closed Lina2689 closed 8 months ago
Package | Line Rate | Health |
---|---|---|
admiral | 98% | ✔ |
Summary | 98% (4723 / 4811) | ✔ |
Thanks @Lina2689 - I'm just wondering if we need a test set up to make sure this is behaving appropriately?? @bundfussr WDYT??
Perhaps there is already one??
Yes, a test for the case that order
is not specified and duplicates in dataset_add
with respect to by_vars
is a good idea.
@bundfussr & @bms63 , I have added test cases when order is not specified and also updated the description in header. Can you please review and let me know if anything needs to be updated.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()