pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
224 stars 63 forks source link

Closes #2326 check_type documentation is updated for argument details. #2345

Closed Lina2689 closed 8 months ago

Lina2689 commented 8 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 8 months ago

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4723 / 4811)
bundfussr commented 8 months ago

Thanks @Lina2689 - I'm just wondering if we need a test set up to make sure this is behaving appropriately?? @bundfussr WDYT??

Perhaps there is already one??

Yes, a test for the case that order is not specified and duplicates in dataset_add with respect to by_vars is a good idea.

Lina2689 commented 8 months ago

@bundfussr & @bms63 , I have added test cases when order is not specified and also updated the description in header. Can you please review and let me know if anything needs to be updated.