pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
220 stars 62 forks source link

Closes #1839 #2359

Closed jasdumas closed 6 months ago

jasdumas commented 6 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 6 months ago

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4731 / 4819)
bms63 commented 6 months ago

WE also like our news/changelog!! NEed an entry for that and did you have success building the website?

jasdumas commented 6 months ago

@bms63 I've updated the branch with a test and updates to the NEWS.md file. I did successfully build and preview the {pkgdown} website 🎉

I hit a few roadblocks with this dummy issue almost entirely because I needed to install many dependency packages since I updated R 🙃

bms63 commented 6 months ago

Umm....devtools::install_dev_dep(dependencies=TRUE) would of grabbed them all for you!! Sorry for the hassle, but glad you finished it out!

This looks great! @zdz2101 any words of wisdom?

zdz2101 commented 6 months ago

Looks great to me, other than Ben's one-time-use advice of running devtools::install_dev_deps(dependencies = TRUE) , think we can close w/o merging, feel free to pick up new issues as soon as you are comfortable @jasdumas