Closed jasdumas closed 6 months ago
Package | Line Rate | Health |
---|---|---|
admiral | 98% | ✔ |
Summary | 98% (4731 / 4819) | ✔ |
WE also like our news/changelog!! NEed an entry for that and did you have success building the website?
@bms63 I've updated the branch with a test and updates to the NEWS.md file. I did successfully build and preview the {pkgdown} website 🎉
I hit a few roadblocks with this dummy issue almost entirely because I needed to install many dependency packages since I updated R 🙃
Umm....devtools::install_dev_dep(dependencies=TRUE)
would of grabbed them all for you!! Sorry for the hassle, but glad you finished it out!
This looks great! @zdz2101 any words of wisdom?
Looks great to me, other than Ben's one-time-use advice of running devtools::install_dev_deps(dependencies = TRUE)
, think we can close w/o merging, feel free to pick up new issues as soon as you are comfortable @jasdumas
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()