closes :1839 dummy fnc created

[santarabantoosoo]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• [ ] Place Closes # into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• [ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• [ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• [ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• [ ] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF version of it to the same folder.
• [ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• [ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• [ ] Address any updates needed for vignettes and/or templates
• [ ] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• [ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• [ ] Address or fix all lintr warnings and errors - lintr::lint_package()
• [ ] Run R CMD check locally and address all errors and warnings - devtools::check()
• [ ] Link the issue in the Development Section on the right hand side.
• [ ] Address all merge conflicts and resolve appropriately
• [ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

[santarabantoosoo]

@zdz2101 any idea why did I fail the CI/CD workflow ?

[santarabantoosoo]

also when I tried to:

Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately

I ran into a dependency error that couldn't be solved

[bms63]

Hi @santarabantoosoo

• The news file should be in the top directory not in the R folder
• The test file for your function should go in the test folder
• Take a look at the other roxygen headers to see how they are written - you are missing a few key pieces. :)

[zdz2101]

also when I tried to:

Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately

I ran into a dependency error that couldn't be solved

Can you screenshot your issue regarding the devtools::document() portion? Make sure you also have run devtools::install_dev_deps(dependencies = TRUE) to ensure you have all the packages necessary to build admiral

[santarabantoosoo]

Thanks a lot

@bms63 @zdz2101

I think I have solved all the issues above and devtools::document() is now working

I am still facing some errors with the CI/CD. I am trying to figure them out.

[zdz2101]

@santarabantoosoo you need to still commit and push the .Rd file that was created from devtools::document() and move the test-.xxx file to the tests/testthat folder

[zdz2101]

Closing in favor of https://github.com/pharmaverse/admiral/pull/2371