pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
224 stars 63 forks source link

closes # 1839 dummy function and test created #2368

Closed abeerzaki closed 7 months ago

abeerzaki commented 7 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

zdz2101 commented 7 months ago

Please move the test file to the appropriate tests/testthat/ folder then run devtools::document() to grab the appropriate roxygen documentation from your function as well

zdz2101 commented 7 months ago

@abeerzaki In the future, you would want to add a NEWS entry, but for the most part this looks good. Don't worry about the CI/CD checks failing, it's likely something else we need to address, will close this PR now, feel free to begin contributing as soon as you're comfortable