Closed bms63 closed 5 months ago
Package | Line Rate | Health |
---|---|---|
admiral | 98% | ✔ |
Summary | 98% (4730 / 4818) | ✔ |
Anyways I don’t think k remotes is actually needed
Anyways I don’t think k remotes is actually needed
Remotes isn't needed for the workflows that run on CI/CD if that workflow uses staged deps to set up the packages. If a workflow isn't using staged deps, it will fail without Remotes. Also an annoying thing that happens to users is they come across the admiral repo and install it from GitHub it won't work because you need the dev version of admiraldev and without Remotes, there is no way for the installation process to know where to get it from.
It's fine for us, the devs, to depend on tools like staged deps. But we should keep up our repo in a state so that anyone coming to the repo can install the package. This means adding Remotes when we depend on dev versions of packages.
Anyways I don’t think k remotes is actually needed
Remotes isn't needed for the workflows that run on CI/CD if that workflow uses staged deps to set up the packages. If a workflow isn't using staged deps, it will fail without Remotes. Also an annoying thing that happens to users is they come across the admiral repo and install it from GitHub it won't work because you need the dev version of admiraldev and without Remotes, there is no way for the installation process to know where to get it from.
It's fine for us, the devs, to depend on tools like staged deps. But we should keep up our repo in a state so that anyone coming to the repo can install the package. This means adding Remotes when we depend on dev versions of packages.
Ah okay - I was thinking that our CI could use remotes now (thought that was a reason to rework CI R-CMD checks).
makes sense for users wishing to install dev versions
If everything looks okay can you approve so we can update the other PRs to pass CI
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()