pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
220 stars 61 forks source link

Closes #2378 add test for `get_imputation_target_date()` #2386

Closed zdz2101 closed 5 months ago

zdz2101 commented 5 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 5 months ago

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4730 / 4818)
zdz2101 commented 5 months ago

@bms63 @millerg23 I was mistaken in that the internal functions weren't being loaded in the test suite, I probably had somethin wrong with my session, nothing needs to be done to address this, just regular ol' additional tests

millerg23 commented 5 months ago

I assume failing checks are around ERROR message updates. Happy to Approve this, once checks running clean.

bms63 commented 5 months ago

@zdz2101 @millerg23 is this one good to merge?

zdz2101 commented 5 months ago

@zdz2101 @millerg23 is this one good to merge?

Should be once cicd goes through!