pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
220 stars 61 forks source link

Closes #2392 update adpc adpp for urine #2393

Closed jeffreyad closed 5 months ago

jeffreyad commented 5 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 5 months ago

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4730 / 4818)
zdz2101 commented 5 months ago

The errors that would fix the adpc/adpp data are here, but the errors that would fix the admiraldev warning stuff is in #2372 , but that one has the errors that would be fixed here, so I just migrated the change here as well to get a clean github actions ci/cd @bms63 , looks good to go, the links is a brand new thing that I suspect works as is/just fine, maybe just a weird one-off issue, the link to on current website still works, dont see why it would break out of nowhere now

bms63 commented 5 months ago

The errors that would fix the adpc/adpp data are here, but the errors that would fix the admiraldev warning stuff is in #2372 , but that one has the errors that would be fixed here, so I just migrated the change here as well to get a clean github actions ci/cd @bms63 , looks good to go, the links is a brand new thing that I suspect works as is/just fine, maybe just a weird one-off issue, the link to on current website still works, dont see why it would break out of nowhere now

Thanks @zdz2101!!