Closed ProfessorP-beep closed 4 months ago
Thank you for fixing that one!! We have some more challenging issues if you would like to jump in the deep end. I can try and pick one out. If not, I think the low hanging fruit is already picked, but new issues come in pretty regularly.
@bms63 Yea, sure! If there is one you suggest I can hop on or take a look at the open list.
Yea, sure! If there is one you suggest I can hop on or take a look at the open list.
One of our goals for 1.1 release (happening in June) is to improve error messaging to users. This issue, https://github.com/pharmaverse/admiral/issues/2404, is part of that effort.
Check out admiraldev repo to see what we are doing under the hood for our assert functions and to glean some more understanding of our efforts. Feel free to ask questions!!
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()