Closes #2265 update basket_select function

[millerg23]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• [x] Place Closes # into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• [x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• [x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• [x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• [x] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF version of it to the same folder.
• [x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• [x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• [x] Address any updates needed for vignettes and/or templates
• [x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• [x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• [x] Address or fix all lintr warnings and errors - lintr::lint_package()
• [x] Run R CMD check locally and address all errors and warnings - devtools::check()
• [x] Link the issue in the Development Section on the right hand side.
• [x] Address all merge conflicts and resolve appropriately
• [x] Pat yourself on the back for a job well done! Much love to your accomplishment!

[millerg23]

@bundfussr @bms63 would appreciate an initial QC of what I have done. I need to create some tickets for the failing unit tests, these are due to ERROR message updates in admiraldev (there may already be tickets for all/some of them). I think update allows us in Roche to handle Implementation Status for SMQs, and also reading output from get_meddra_basket_pt (Roche) function. One question I had was around the format.basket_select function, is this still needed with the new ERROR messaging using cli_abort(), if it is, then this probably needs updated to handle the new ... argument (any tips welcome!)

[bundfussr]

One question I had was around the format.basket_select function, is this still needed with the new ERROR messaging using cli_abort(), if it is, then this probably needs updated to handle the new ... argument (any tips welcome!)

Yes, it is still needed and it should be updated. I would display the extra arguments in the same way as the standard arguments, i.e., "<name> = <value>".

[github-actions[bot]]

This Pull Request is stale because it has not been worked on in 15 days.

[github-actions[bot]]

Package	Line Rate	Health
admiral	97%	✔
Summary	97% (4697 / 4826)	✔

[millerg23]

I updated unit tests and format.basket_select. Can you please review again.

[millerg23]

BTW should I fix links in this MR, or is something going wrong elsewhere? Its not related to these changes.

[millerg23]

@bms63 myself and Stefan had a meeting, and with these updates it satisfies the Roche needs for company specific options. Let me know if I need to do anything else.