Closed millerg23 closed 3 months ago
@bundfussr @bms63 would appreciate an initial QC of what I have done. I need to create some tickets for the failing unit tests, these are due to ERROR message updates in admiraldev (there may already be tickets for all/some of them).
I think update allows us in Roche to handle Implementation Status
for SMQs, and also reading output from get_meddra_basket_pt
(Roche) function.
One question I had was around the format.basket_select
function, is this still needed with the new ERROR messaging using cli_abort()
, if it is, then this probably needs updated to handle the new ...
argument (any tips welcome!)
One question I had was around the
format.basket_select
function, is this still needed with the new ERROR messaging usingcli_abort()
, if it is, then this probably needs updated to handle the new...
argument (any tips welcome!)
Yes, it is still needed and it should be updated. I would display the extra arguments in the same way as the standard arguments, i.e., "<name> = <value>"
.
This Pull Request is stale because it has not been worked on in 15 days.
Package | Line Rate | Health |
---|---|---|
admiral | 97% | ✔ |
Summary | 97% (4697 / 4826) | ✔ |
I updated unit tests and format.basket_select
. Can you please review again.
BTW should I fix links in this MR, or is something going wrong elsewhere? Its not related to these changes.
@bms63 myself and Stefan had a meeting, and with these updates it satisfies the Roche needs for company specific options. Let me know if I need to do anything else.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()