Closed StefanThoma closed 4 months ago
I get a strange error in the test suite apparently independent of my code:
Error in derive_param_tte()
:
! For some values of "PARAMCD" there is more than one value of "AEDECOD"
ℹ Call get_one_to_many_dataset()
to get all one-to-many values.
Where the test expects the error as:
regexp = paste0(
"For some values of PARAMCD there is more than one value of AEDECOD.\n",
"Call get_one_to_many_dataset()
to get all one to many values."
)
I can replace this with a snapshot test, maybe!
There appears also a deprecation warning:
Warning ('test-derive_param_tte.R:45:3'): derive_param_tte Test 1: new observations with analysis date are derived correctly ──
enumerate()
was deprecated in admiraldev 1.1.0.
Package | Line Rate | Health |
---|---|---|
admiral | 98% | ✔ |
Summary | 98% (4732 / 4820) | ✔ |
There appears also a deprecation warning:
Warning ('test-derive_param_tte.R:45:3'): derive_param_tte Test 1: new observations with analysis date are derived correctly ──
enumerate()
was deprecated in admiraldev 1.1.0.
I'm currently trying to fix these in https://github.com/pharmaverse/admiral/issues/2413.
@zdz2101
I have added an assert statement into dt_level
.
I believe this is consistent with what input we would expect, i.e. a character scalar of one of the options.
Can you confirm?
Added assertion to dt_level function to deal with unexpected inputs
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()