Closed bms63 closed 4 months ago
Hi all,
I made a collapsible News section for tracking Developer Notes/Issues.
I think going forward we are going to be making more under the hood changes and I'd like to track these things. I'm a bit weary of using Milestones as I like everything being in one file with minimal fuss.
Best to view the News.md files as rendered - https://github.com/pharmaverse/admiral/blob/2370-general-issue-developer-notes-in-newsmd-and-documenting-under-the-hood-changes/NEWS.md
Curious to see how it looks on the website once merged
Package | Line Rate | Health |
---|---|---|
admiral | 98% | ✔ |
Summary | 98% (4732 / 4820) | ✔ |
Looks like the staged dependencies stuff is breaking across the board, @pharmaverse/admiral the issue is also showing in other repos like pharmaverseadam
Looks like the staged dependencies stuff is breaking across the board, @pharmaverse/admiral the issue is also showing in other repos like
pharmaverseadam
I believe this is due to our updates happening in admiraldev
Looks like the staged dependencies stuff is breaking across the board, @pharmaverse/admiral the issue is also showing in other repos like
pharmaverseadam
I believe this is due to our updates happening in
admiraldev
it's been fixed/addressed between yesterday and today
Curious to see how it looks on the website once merged
@bms63 , unfortunately the link to the image is broken on the website:
ummm....as much as I appreciated the image, I kind of didn't like how much "real estate" it took over. Sort of why I wanted to reduce the visibility of developer specific updates.
I'm inclined to just remove the image.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()