Closes #2413 abort_query_data: replace calls to deprecated functions and use cli for messages

[bundfussr]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• [x] Place Closes # into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• [x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• [x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• [x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• [x] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF version of it to the same folder.
• [x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• [x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• [x] Address any updates needed for vignettes and/or templates
• [x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• [x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• [x] Address or fix all lintr warnings and errors - lintr::lint_package()
• [x] Run R CMD check locally and address all errors and warnings - devtools::check()
• [x] Link the issue in the Development Section on the right hand side.
• [x] Address all merge conflicts and resolve appropriately
• [x] Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions[bot]]

Package	Line Rate	Health
admiral	97%	✔
Summary	97% (4690 / 4818)	✔

[bundfussr]

I have merged the 2403-cli_abort branch into this one to pass the checks.

[zdz2101]

I have merged the 2403-cli_abort branch into this one to pass the checks.

Just to be clear this PR essentially contains all the changes made in https://github.com/pharmaverse/admiral/pull/2412 ?

[bundfussr]

Just to be clear this PR essentially contains all the changes made in #2412 ?

Yes

[bms63]

@bundfussr amazing work!! The snapshpts really help with reviewing the informative/warning/error messages!! I'm wondering if we should push more in that direction for everything. I spotted a few typos and redundant messages.

Also, I started questioning the return of sub-functions in the error messages as they are not explicitly called by the users - perhaps something for us to mull over as it might lead to some confusion.

[bms63]

@kaz462 @manciniedoardo @sadchla-codes @zdz2101 @millerg23

Hi all. It would be really helpful if you all, at the minimum, can look over the snapshots and see if the error/warnings messages make sense. It was really nice way to review this stuff, i.e. the snapshots. I spotted some typos, missing words and so having more eyes on this would be really helpful. Some of these typos have been around for a while - eeehh!!

Going deeper is also appreciated, but would love to get this merged in by EOD Tuesday.

[bms63]

Okay! It got weird for a minute, but now we are back on track!! Thank you @bundfussr for this update!!

[kaz462]

@bms63 @bundfussr I just did a review and left some comments, all minor stuff, maybe I can update with a new PR?

[bms63]

@bms63 @bundfussr I just did a review and left some comments, all minor stuff, maybe I can update with a new PR?

oh no!! sorry @kaz462 - yes please restore the branch and create a new PR. I don't think the code will show differences anymore, but you can just refer to this one and @bundfussr can update. thanks!!

[kaz462]

oh no!! sorry @kaz462 - yes please restore the branch and create a new PR. I don't think the code will show differences anymore, but you can just refer to this one and @bundfussr can update. thanks!!

All good! I went ahead and updated here: https://github.com/pharmaverse/admiral/pull/2423