Closed bundfussr closed 4 months ago
Package | Line Rate | Health |
---|---|---|
admiral | 97% | ✔ |
Summary | 97% (4690 / 4818) | ✔ |
I have merged the 2403-cli_abort
branch into this one to pass the checks.
I have merged the
2403-cli_abort
branch into this one to pass the checks.
Just to be clear this PR essentially contains all the changes made in https://github.com/pharmaverse/admiral/pull/2412 ?
Just to be clear this PR essentially contains all the changes made in #2412 ?
Yes
@bundfussr amazing work!! The snapshpts really help with reviewing the informative/warning/error messages!! I'm wondering if we should push more in that direction for everything. I spotted a few typos and redundant messages.
Also, I started questioning the return of sub-functions in the error messages as they are not explicitly called by the users - perhaps something for us to mull over as it might lead to some confusion.
@kaz462 @manciniedoardo @sadchla-codes @zdz2101 @millerg23
Hi all. It would be really helpful if you all, at the minimum, can look over the snapshots and see if the error/warnings messages make sense. It was really nice way to review this stuff, i.e. the snapshots. I spotted some typos, missing words and so having more eyes on this would be really helpful. Some of these typos have been around for a while - eeehh!!
Going deeper is also appreciated, but would love to get this merged in by EOD Tuesday.
Okay! It got weird for a minute, but now we are back on track!! Thank you @bundfussr for this update!!
@bms63 @bundfussr I just did a review and left some comments, all minor stuff, maybe I can update with a new PR?
@bms63 @bundfussr I just did a review and left some comments, all minor stuff, maybe I can update with a new PR?
oh no!! sorry @kaz462 - yes please restore the branch and create a new PR. I don't think the code will show differences anymore, but you can just refer to this one and @bundfussr can update. thanks!!
oh no!! sorry @kaz462 - yes please restore the branch and create a new PR. I don't think the code will show differences anymore, but you can just refer to this one and @bundfussr can update. thanks!!
All good! I went ahead and updated here: https://github.com/pharmaverse/admiral/pull/2423
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()