Closed manciniedoardo closed 2 months ago
@bms63 @bundfussr I added the example by adding ADT
and ADTF
variables to the advs
object. I did it on a new line to avoid overflowing past 100 chars in the tibble, not sure if this is the best approach though as it's not super neat?
@w316liu please feel free to take a look as well!
Package | Line Rate | Health |
---|---|---|
admiral | 97% | ✔ |
Summary | 97% (4685 / 4813) | ✔ |
The error is still persisting :(
The error is still persisting :(
fixed now
Closes #2338
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()