pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

Closes #2338: keep_nas = TRUE example in derive_param_computed() documentation #2428

Closed manciniedoardo closed 2 months ago

manciniedoardo commented 2 months ago

Closes #2338

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

manciniedoardo commented 2 months ago

@bms63 @bundfussr I added the example by adding ADT and ADTF variables to the advs object. I did it on a new line to avoid overflowing past 100 chars in the tibble, not sure if this is the best approach though as it's not super neat?

@w316liu please feel free to take a look as well!

github-actions[bot] commented 2 months ago

Code Coverage

Package Line Rate Health
admiral 97%
Summary 97% (4685 / 4813)
bms63 commented 2 months ago

The error is still persisting :(

manciniedoardo commented 2 months ago

The error is still persisting :(

fixed now