pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
222 stars 62 forks source link

Closes: #1839 creates dummy function #2430

Closed tuiaj closed 4 months ago

tuiaj commented 4 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

tuiaj commented 4 months ago

Here's my attempt at a pull request with the dummy function, issue #1839 !

I couldn't create a branch in the pharmaverse's admiral repo, so I forked to my account, created a dummy branch then requested to merge back to pharmaverse's admiral/main?

@bms63 @jeffreyad

bms63 commented 4 months ago

I added you to the repo @tuiaj - thanks for doing the dummy PR. Do you have any questions?

bms63 commented 4 months ago

@tuiaj can you check linting, spelling and code styling please. those ci actions fell over.

bms63 commented 4 months ago

Hey @tuiaj just checking if you are aiming to complete this soon?