pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

2404 general issue ensure argument name is correct in error messages #2431

Closed ProfessorP-beep closed 2 months ago

ProfessorP-beep commented 2 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

ProfessorP-beep commented 2 months ago

@bms63 Hey Ben, this needs to be pushed to admiraldev right? I haven't been able to create a branch there or change where this one is linked to as I go over the checks.

bms63 commented 2 months ago

ummm...something is amiss here :) 290 files changed seems a bit much!!

bms63 commented 2 months ago

I add you to admiraldev repo. Let me know if you need any help!

manciniedoardo commented 2 months ago

Closing this PR in light of changes being made in admiraldev instead - see here