pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

[skip vbump] admiral v1.1.0 #2432

Closed manciniedoardo closed 1 month ago

manciniedoardo commented 2 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

manciniedoardo commented 2 months ago

This PR is a draft at the moment. If you are doing any work related to #2394 please use this branch and we will merge everything in one go.

github-actions[bot] commented 2 months ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4883 / 5082)
github-actions[bot] commented 1 month ago

This Pull Request is stale because it has not been worked on in 15 days.

bms63 commented 1 month ago

@manciniedoardo @bundfussr @ddsjoberg I think this is it - you guys see anything amiss?

manciniedoardo commented 1 month ago

LGTM

bundfussr commented 1 month ago

Shouldn't we have "[skip vbump]" in the title to avoid that the version is changed to 1.1.0.9000?

bms63 commented 1 month ago

Shouldn't we have "[skip vbump]" in the title to avoid that the version is changed to 1.1.0.9000?

I placed this in the Release Task List as well image

manciniedoardo commented 1 month ago

great spot @bundfussr !