pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
222 stars 62 forks source link

Closes #2446 Cleaned up and alphabetized admiral-pacakges.R #2449

Closed gg106046 closed 4 months ago

gg106046 commented 4 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 4 months ago

Code Coverage

Package Line Rate Health
admiral 97%
Summary 97% (4728 / 4859)
StefanThoma commented 4 months ago

Hi @bms63 Is it possible you did not run devtools::document()? When I run it on my updated from master branch I get a lot of man/ files with just ordered lines.

bms63 commented 4 months ago

Hi @bms63 Is it possible you did not run devtools::document()? When I run it on my updated from master branch I get a lot of man/ files with just ordered lines.

The check passed for documentation. I'm not sure what you mean by ordered lines - screenshot?

Are you using the correct roxygen version in the DESCRIPTION?

StefanThoma commented 4 months ago

Ah no I think I am not using the correct version, let me double check.

StefanThoma commented 4 months ago

You are right, all good :)