Closes #2442 Fixed advs template and vignette

[StefanThoma]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• [x] Place Closes # into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• [x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• [x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• [x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• [x] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF version of it to the same folder.
• [x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• [x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• [x] Address any updates needed for vignettes and/or templates
• [x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
• [x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• [x] Address or fix all lintr warnings and errors - lintr::lint_package()
• [x] Run R CMD check locally and address all errors and warnings - devtools::check()
• [x] Link the issue in the Development Section on the right hand side.
• [x] Address all merge conflicts and resolve appropriately
• [x] Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions[bot]]

Package	Line Rate	Health
admiral	97%	✔
Summary	97% (4728 / 4859)	✔

[StefanThoma]

@bms63 & @manciniedoardo In the ad_adpp template:

pp$PPSTRESC is not a character variable but of type double. all.equal(pp$PPSTRESC, pp$PPSTRESN) is TRUE except for attributes. Is this an error?

All values are numeric, so ADPP AVALC is also all numeric. Therefore, AVALC should not be mapped in the template, right? Or would we expect non-numeric information in pp datasets in general?

[manciniedoardo]

@bms63 & @manciniedoardo In the ad_adpp template:

pp$PPSTRESC is not a character variable but of type double. all.equal(pp$PPSTRESC, pp$PPSTRESN) is TRUE except for attributes. Is this an error?

All values are numeric, so ADPP AVALC is also all numeric. Therefore, AVALC should not be mapped in the template, right? Or would we expect non-numeric information in pp datasets in general?

@jeffreyad any thoughts?

[bms63]

@bms63 & @manciniedoardo In the ad_adpp template:

pp$PPSTRESC is not a character variable but of type double. all.equal(pp$PPSTRESC, pp$PPSTRESN) is TRUE except for attributes. Is this an error?

All values are numeric, so ADPP AVALC is also all numeric. Therefore, AVALC should not be mapped in the template, right? Or would we expect non-numeric information in pp datasets in general?

AVALC should always be character. Perhaps this is a mistake in the PP dataset.

[jeffreyad]

@bms63 & @manciniedoardo In the ad_adpp template: pp$PPSTRESC is not a character variable but of type double. all.equal(pp$PPSTRESC, pp$PPSTRESN) is TRUE except for attributes. Is this an error? All values are numeric, so ADPP AVALC is also all numeric. Therefore, AVALC should not be mapped in the template, right? Or would we expect non-numeric information in pp datasets in general?

@jeffreyad any thoughts?

Thanks, I put in a PR to update pp$PPSTRESC

https://github.com/pharmaverse/pharmaversesdtm/pull/103

[bms63]

Thanks @jeffreyad!! we might need to use remotes for pharmaversesdtm @StefanThoma to get the latest once it is merged in.

[StefanThoma]

Thanks @jeffreyad!! we might need to use remotes for pharmaversesdtm @StefanThoma to get the latest once it is merged in.

For ADPP I just remove AVALC altogether.

[bms63]

Something amiss with the code style and the templates

[StefanThoma]

Something amiss with the code style and the templates

Thanks, should be good now!

[bms63]

Thanks again @StefanThoma for jumping in on this one!!