pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

Closes #2405 update messaging for duplicates in derive_extreme_event() #2454

Closed jeffreyad closed 1 month ago

jeffreyad commented 1 month ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

jeffreyad commented 1 month ago

@bundfussr I don't think this does everything we wanted, but it may be step in the right direction.

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4822 / 5017)
bms63 commented 1 month ago

@bundfussr if you have time, please check this one. If not not we can save for 1.2 release.

@jeffreyad can we add some tests around these messages if we go forward? If you don't have time, maybe we should definitely wait until 1.2 release

bms63 commented 1 month ago

@jeffreyad do you have time today to finish updates? If not, we can just push to 1.2!! You have done enough !! :)