Closed bms63 closed 1 month ago
Package | Line Rate | Health |
---|---|---|
admiral | 96% | ✔ |
Summary | 96% (4883 / 5082) | ✔ |
Looks like there are 8 files changed instead of 12.
I think the other four are excluded from the package like the license
Looks like there are 8 files changed instead of 12.
I think the other four are excluded from the package like the license
Ok, I guess we'll find out
Looks like there are 8 files changed instead of 12.
I think the other four are excluded from the package like the license
Ok, I guess we'll find out
You got me paranoid - I took a look again. The CONTRIBUTING.md and .github files also don't go to CRAN. Think we are good!
@bms63 I might be wrong here, but wasn't the CRAN check in pharmaversesdtm
checking the data
folder, ie its the .rda
files that have non-ascii characters??
@millerg23 no it was flagging some characters in our .Rd man pages and DESCRIPTION files, after all.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()