pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

Closes #2456 remove non ascii characters #2457

Closed bms63 closed 1 month ago

bms63 commented 1 month ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4883 / 5082)
bms63 commented 1 month ago

Looks like there are 8 files changed instead of 12.

I think the other four are excluded from the package like the license

jeffreyad commented 1 month ago

Looks like there are 8 files changed instead of 12.

I think the other four are excluded from the package like the license

Ok, I guess we'll find out

bms63 commented 1 month ago

Looks like there are 8 files changed instead of 12.

I think the other four are excluded from the package like the license

Ok, I guess we'll find out

You got me paranoid - I took a look again. The CONTRIBUTING.md and .github files also don't go to CRAN. Think we are good!

image

millerg23 commented 1 month ago

@bms63 I might be wrong here, but wasn't the CRAN check in pharmaversesdtm checking the data folder, ie its the .rda files that have non-ascii characters??

manciniedoardo commented 1 month ago

@millerg23 no it was flagging some characters in our .Rd man pages and DESCRIPTION files, after all.