pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

[skip vbump] Closes #2459 feedback from cran for admiral 110 #2460

Closed bms63 closed 1 month ago

bms63 commented 1 month ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

bms63 commented 1 month ago

I dropped the FAQ link in the concepts vignette. Not worth fussing with that one.

Issue with signal_duplicates fixed.

I already submitted to CRAN to see if we could get it approved before I sign on tomorrow. Hopefully, nothing amiss!! eeehhh!!

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4883 / 5082)