pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

[skip vbump] Closes #2462 fix_derive_extreme_event: re-enable check_type = "none" #2463

Closed bundfussr closed 1 month ago

bundfussr commented 1 month ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4896 / 5095)
bms63 commented 1 month ago

@bundfussr just thinking - is this critical or can we wait another week or two to see if anything else comes up?

bundfussr commented 1 month ago

@bundfussr just thinking - is this critical or can we wait another week or two to see if anything else comes up?

It is not supercritical but it breaks admiralonco. I.e., we can wait some days but we need to fix it within two weeks. Otherwise admiralonco will be removed from CRAN.

bms63 commented 1 month ago

If okay, let's get the fix out on Monday June 17th to see if anything else surfaces.

Can you all point to this branch to check everything else is working?

bundfussr commented 1 month ago

@bms63 , by the way, did you run the reverse dependencies checks before submitting to CRAN?

bms63 commented 1 month ago

@bms63 , by the way, did you run the reverse dependencies checks before submitting to CRAN?

Yes - admiralonco, optha and vaccines came up. We also github searched it and found datacutr and sdtm.oak (not on CRAN) were using admrialdev and admiral.