Closed bundfussr closed 1 month ago
Package | Line Rate | Health |
---|---|---|
admiral | 96% | ✔ |
Summary | 96% (4896 / 5095) | ✔ |
@bundfussr just thinking - is this critical or can we wait another week or two to see if anything else comes up?
@bundfussr just thinking - is this critical or can we wait another week or two to see if anything else comes up?
It is not supercritical but it breaks admiralonco. I.e., we can wait some days but we need to fix it within two weeks. Otherwise admiralonco will be removed from CRAN.
If okay, let's get the fix out on Monday June 17th to see if anything else surfaces.
Can you all point to this branch to check everything else is working?
@bms63 , by the way, did you run the reverse dependencies checks before submitting to CRAN?
@bms63 , by the way, did you run the reverse dependencies checks before submitting to CRAN?
Yes - admiralonco, optha and vaccines came up. We also github searched it and found datacutr and sdtm.oak (not on CRAN) were using admrialdev and admiral.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()