Closed bundfussr closed 2 weeks ago
Package | Line Rate | Health |
---|---|---|
admiral | 96% | ✔ |
Summary | 96% (4952 / 5151) | ✔ |
Sorry I still want to review more thoroughly. Can we not merge until I complete please.
LGTM - only comment is, can we showcase this new function in a vignette? What about here or right after?
Yes, good idea. I'll add an example there.
What do you think about a MCRIT flag for multiple responses? Worth to make a related function?
Worth to give more reasoning to a user on why these flags might be useful?
oohhh could we have a similar example with the AND condition - this is from ADaM IG
LGTM - only comment is, can we showcase this new function in a vignette? What about here or right after?
@manciniedoardo , I have added an example. It is also a nice use case of our higher order functions.
oohhh could we have a similar example with the AND condition - this is from ADaM IG
@bms63 , I have added this example to the bds_finding vignette.
Worth to give more reasoning to a user on why these flags might be useful?
@bms63 , I've added it to the description of the function.
What do you think about a MCRIT flag for multiple responses? Worth to make a related function?
I wouldn't implement an MCRIT
specific function because there are almost no restrictions on the values of the MCRIT*
variables. However, a function for creating variable pairs like MCRITyFL
/MCRITyFN
in one go would be useful. See https://github.com/pharmaverse/admiral/issues/2480.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()