pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

Closes #2468 Implement derive_vars_crit_flag() #2469

Closed bundfussr closed 2 weeks ago

bundfussr commented 3 weeks ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 3 weeks ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4952 / 5151)
bms63 commented 3 weeks ago

Sorry I still want to review more thoroughly. Can we not merge until I complete please.

bundfussr commented 2 weeks ago

LGTM - only comment is, can we showcase this new function in a vignette? What about here or right after?

Yes, good idea. I'll add an example there.

bms63 commented 2 weeks ago

What do you think about a MCRIT flag for multiple responses? Worth to make a related function?

bms63 commented 2 weeks ago

Worth to give more reasoning to a user on why these flags might be useful? image

bms63 commented 2 weeks ago

oohhh could we have a similar example with the AND condition - this is from ADaM IG image

bundfussr commented 2 weeks ago

LGTM - only comment is, can we showcase this new function in a vignette? What about here or right after?

@manciniedoardo , I have added an example. It is also a nice use case of our higher order functions.

bundfussr commented 2 weeks ago

oohhh could we have a similar example with the AND condition - this is from ADaM IG image

@bms63 , I have added this example to the bds_finding vignette.

bundfussr commented 2 weeks ago

Worth to give more reasoning to a user on why these flags might be useful? image

@bms63 , I've added it to the description of the function.

bundfussr commented 6 days ago

What do you think about a MCRIT flag for multiple responses? Worth to make a related function?

I wouldn't implement an MCRIT specific function because there are almost no restrictions on the values of the MCRIT* variables. However, a function for creating variable pairs like MCRITyFL/MCRITyFN in one go would be useful. See https://github.com/pharmaverse/admiral/issues/2480.