Closed AndersAskeland closed 3 weeks ago
Package | Line Rate | Health |
---|---|---|
admiral | 96% | ✔ |
Summary | 96% (4899 / 5098) | ✔ |
Nice job @AndersAskeland - looks almost perfect, only thing i've notice is that the issue seems not to have linked automatically. Maybe try adding the text in your PR text or just add it manually in the "Development" section.
Woops. Did not notice that. Should be linked now 👍
Great job @AndersAskeland ! You're all set now.
Closes #1839
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()