pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

Closes #1839 dummy function created #2471

Closed AndersAskeland closed 3 weeks ago

AndersAskeland commented 3 weeks ago

Closes #1839

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 3 weeks ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4899 / 5098)
manciniedoardo commented 3 weeks ago

Nice job @AndersAskeland - looks almost perfect, only thing i've notice is that the issue seems not to have linked automatically. Maybe try adding the text in your PR text or just add it manually in the "Development" section.

AndersAskeland commented 3 weeks ago

Woops. Did not notice that. Should be linked now 👍

manciniedoardo commented 3 weeks ago

Great job @AndersAskeland ! You're all set now.