pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
215 stars 60 forks source link

Closes #1839 dummy function created #2474

Closed Siddhesh2097 closed 2 weeks ago

Siddhesh2097 commented 2 weeks ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 2 weeks ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4899 / 5098)
manciniedoardo commented 2 weeks ago

Great job @Siddhesh2097 - looks almost perfect, just two outstanding tasks:

manciniedoardo commented 2 weeks ago

@Siddhesh2097 looks good now! If you check every item in the tasklist then the final check should pass as well, then you are good to go!

Siddhesh2097 commented 2 weeks ago

Thank You @manciniedoardo. I have checked all items and the final check has passed. I clicked on Ready for Review. Can you tell me the next step, whether I need to close this issue or it will done by you.

manciniedoardo commented 2 weeks ago

@Siddhesh2097 all good now - i will close this PR now and you can start working on admiralmetabolic!

bms63 commented 2 weeks ago

@Siddhesh2097 can I add you to the admiral community team? We ping this team occasionally on admiral developments? It is pretty low engagement ( a couple pings a month at most)

Siddhesh2097 commented 2 weeks ago

@bms63 Sure, please add me