Closed steventing12 closed 2 months ago
Package | Line Rate | Health |
---|---|---|
admiral | 96% | ✔ |
Summary | 96% (4955 / 5154) | ✔ |
@steventing12 thanks for the PR - please give each item in the tasklist a go and shout with any questions/issues.
Hi @steventing12 any issues fixing the last checks?
Hi @steventing12 any issues fixing the last checks?
Hi @manciniedoardo, the checks failed at the spellcheck stage:
Run insightsengineering/r-spellcheck-action@v3 Run options(repos = c(CRAN = "https://cloud.r-project.org/")) Loading required package: spelling Run cd . WORD FOUND IN Rothstein README.md:192
Number of misspelled words: 1 You may correct the spellings of the words above or add them to the "inst/WORDLIST" file by running spelling::update_wordlist() Error: Process completed with exit code 1.
I had run spelling::update_wordlist() but it says no updated required. Any suggestions?
Rothstein
Try manually adding "Rothstein" to inst/wordlist
Looks good, thanks @steventing12 !
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()