pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
224 stars 63 forks source link

Closes #1839 dummy function created #2483

Closed steventing12 closed 2 months ago

steventing12 commented 3 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 3 months ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4955 / 5154)
manciniedoardo commented 3 months ago

@steventing12 thanks for the PR - please give each item in the tasklist a go and shout with any questions/issues.

manciniedoardo commented 2 months ago

Hi @steventing12 any issues fixing the last checks?

steventing12 commented 2 months ago

Hi @steventing12 any issues fixing the last checks?

Hi @manciniedoardo, the checks failed at the spellcheck stage:

Run insightsengineering/r-spellcheck-action@v3 Run options(repos = c(CRAN = "https://cloud.r-project.org/")) Loading required package: spelling Run cd . WORD FOUND IN Rothstein README.md:192

Number of misspelled words: 1 You may correct the spellings of the words above or add them to the "inst/WORDLIST" file by running spelling::update_wordlist() Error: Process completed with exit code 1.

I had run spelling::update_wordlist() but it says no updated required. Any suggestions?

manciniedoardo commented 2 months ago

Rothstein

Try manually adding "Rothstein" to inst/wordlist

manciniedoardo commented 2 months ago

Looks good, thanks @steventing12 !