Closed bms63 closed 2 weeks ago
I'll take this one :)
Are you still able to complete this?
Yeah planning to do it by the end of the month. Does that work for you?
Yeah planning to do it by the end of the month. Does that work for you?
Perfect!
@bms63
There is one function that has been superseded but does not call the deprecate_warn or deprecate_error directly, only via deprecated arguments, get_summary_records
:
r lifecycle::badge("superseded")
Should I remove this function?
@bms63
There is one function that has been superseded but does not call the deprecate_warn or deprecate_error directly, only via deprecated arguments,
get_summary_records
:' Create Summary Records #' #' @description #' #'
r lifecycle::badge("superseded")
Should I remove this function?
We are leaving that function in for a long time even though it has been replaced. It can just keep the superseded badge.
Background Information
These function arguments should be further deprecated or removed
Please follow this guidance when deprecating https://pharmaverse.github.io/admiraldev/dev/articles/programming_strategy.html#deprecation
Definition of Done
@pharmaverse/admiral @pharmaverse/admiral_comm this is a good one to knock out!! Very helpful to us to do this in the beginning of the cycle!