pharmaverse / admiral

ADaM in R Asset Library
https://pharmaverse.github.io/admiral
Apache License 2.0
224 stars 63 forks source link

Closes #2496: added orcids #2497

Closed manciniedoardo closed 2 months ago

manciniedoardo commented 2 months ago

Closes #2496

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

manciniedoardo commented 2 months ago

@StefanThoma let's give everyone a couple of days to shout if they'd like their ORCIDs added too (I left a comment in #2496), and then we can merge.

github-actions[bot] commented 2 months ago

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4952 / 5151)
bms63 commented 2 months ago

@pharmaverse/admiral Anyone else want to add their fancy orchid ids? Will merge this EOD tomorrow.