Open StefanThoma opened 6 days ago
I would be hesitant to make these into unit tests as they are very big files to run.
The current CI check for the templates is a separate workflow. I was thinking we would build off that one - pharmaverse/admiralci/.github/workflows/check-templates.yml@main
I see your point. The downside with a separate run is that you cannot run it locally, afaik.
What about how Edoardo approached that new check in the blog? He sources a file in the workflow - maybe something to consider? Then you could grab the file and run it
Yeah that would not be a bad idea. Let me experiment a bit.
The downside with a separate run is that you cannot run it locally, afaik.
We could implement a function which runs a specified list of templates and compares the results with the references datasets (in pharmaverseadam?).
This function could then be used in the CI/CD workflow and also be called locally.
The downside with a separate run is that you cannot run it locally, afaik.
We could implement a function which runs a specified list of templates and compares the results with the references datasets (in pharmaverseadam?).
This function could then be used in the CI/CD workflow and also be called locally.
That sounds like a good idea.
Background Information
It would be ideal to have a way to verify whether the outputs of the templates have changed.
One idea would be to write unit tests, so that running the unit tests would already check that. I think it could be done like this in a unit test:
Definition of Done
Either find a way of verifying the outputs of the templates, or to decide that this is not necessary.