search

pharmaverse / admiralci

CI/CD workflows used across the admiral family of packages
https://pharmaverse.github.io/admiralci
Other
13 stars 4 forks source link

Modify building rcmd matrix #192

Open galachad opened 3 months ago

galachad commented 3 months ago

This PR is generated matrix before execution.

In the current situation, we were showing the job as complete.

image

With this PR we executed devel only on initial condition.

image

@cicdguy kindly asked for review.

cicdguy commented 3 months ago

I don't think @bms63 likes to see this kind of stuff in the PR check status:

Screenshot 2024-07-23 at 7 44 44 AM

I'll leave it for him and others to decide. Technically this is okay for me though.

galachad commented 3 months ago

I don't think @bms63 likes to see this kind of stuff in the PR check status:

Screenshot 2024-07-23 at 7 44 44 AM

I'll leave it for him and others to decide. Technically this is okay for me though.

You are right. I added the name to the job, Create R CMD Check matrix please let me know if you have a different suggestion.

bms63 commented 3 months ago

I don't think @bms63 likes to see this kind of stuff in the PR check status: Screenshot 2024-07-23 at 7 44 44 AM I'll leave it for him and others to decide. Technically this is okay for me though.

You are right. I added the name to the job, Create R CMD Check matrix please let me know if you have a different suggestion.

Haha yes I prefer if we could hide this step from the developers. We tend to have newer folks to this stuff and it can be a bit overwhelming having so many CI jobs. IS there any way to fold it into the R CMD Check?

However, I must admit I don't understand what the issue that is being solved here? Can someone please explain? We have some others ask for R-CMD checks and worries out snapshots not being checked as well.