search

pharmaverse / admiraldiscovery

https://pharmaverse.github.io/admiraldiscovery/
Other
1 stars 4 forks source link

Use common Pharmaverse workflows #23

Closed cicdguy closed 8 months ago

cicdguy commented 11 months ago

Closes https://github.com/pharmaverse/admiraldiscovery/issues/21

dgrassellyb commented 8 months ago

@cicdguy : I noticed workflows are not triggered here, is it because it's a PR from a forked repo ?

cicdguy commented 8 months ago

@cicdguy : I noticed workflows are not triggered here, is it because it's a PR from a forked repo ?

Yes that's right. Someone needs to approve the workflow runs. Perhaps @ddsjoberg ?

ddsjoberg commented 8 months ago

There is no button to approve the runs at the moment Perhaps because of the merge conflicts? I'll fix them now, and see if it appears

ddsjoberg commented 8 months ago

@cicdguy hmmm merge conflicts resolved, but the approve runs button is still not here. Also, I suspect if I could approve them, then you could also? Any ideas?

cicdguy commented 8 months ago

@cicdguy hmmm merge conflicts resolved, but the approve runs button is still not here. Also, I suspect if I could approve them, then you could also? Any ideas?

I can't approve them because I do not have write access to this repo, that's why I had to fork it 😅 Who's a repo admin here?

cicdguy commented 8 months ago

Oh wait I'm an admin too?! Okay let me just create a separate PR here.

ddsjoberg commented 8 months ago

I think you and I are the admins 😆😆😆

image