pharmaverse / admiralophtha

Ophthalmology package extension of admiral
https://pharmaverse.github.io/admiralophtha
Apache License 2.0
15 stars 3 forks source link

204 admiral updates #213

Closed manciniedoardo closed 1 year ago

manciniedoardo commented 1 year ago

Closes #204

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

manciniedoardo commented 1 year ago

HI @palmenl @linacrer - since admiral has updated the derive_summary_records() function this require an update to the ADVFQ templates and vignettes. As you are not involved in admiraliophtha much these days I made the update myself but thought I would include you as reviewers so that you could both please double check the output still makes sense etc. Thanks!

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
admiralophtha 96%
Summary 96% (122 / 127)
manciniedoardo commented 1 year ago

@palmenl is this fine to merge?