Closed manciniedoardo closed 1 year ago
HI @palmenl @linacrer - since admiral has updated the derive_summary_records()
function this require an update to the ADVFQ templates and vignettes. As you are not involved in admiraliophtha much these days I made the update myself but thought I would include you as reviewers so that you could both please double check the output still makes sense etc. Thanks!
Package | Line Rate | Health |
---|---|---|
admiralophtha | 96% | ✔ |
Summary | 96% (122 / 127) | ✔ |
@palmenl is this fine to merge?
Closes #204
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()