pharmaverse / admiralophtha

Ophthalmology package extension of admiral
https://pharmaverse.github.io/admiralophtha
Apache License 2.0
15 stars 3 forks source link

Supersede `derive_var_bcvacritxfl()` and update vignettes/templates that use it #247

Open manciniedoardo opened 2 months ago

manciniedoardo commented 2 months ago

Background Information

With the advent of admiral::derive_vars_crit_flag() there is less of a need for admiralophtha::derive_var_bcvacrtixfl(). The latter should be superseded, in line with the {admiral} family's policy to not make many breaking changes post 1.0 releases.

Definition of Done

steventing12 commented 1 month ago

Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()

manciniedoardo commented 1 month ago

Can you please make a pull request with your proposed changes? That way I can review code/changes and propose amendments.