Closed Pierre-Wallet closed 7 months ago
@rossfarrugia , all updates done! It was eventually not a minor update :)
@rossfarrugia , could you please explain me what this "Check Expected — Waiting for status to be reported" means and what action is expected from my side? Thanks!
@rossfarrugia , could you please explain me what this "Check Expected — Waiting for status to be reported" means and what action is expected from my side? Thanks!
Ignore this one Pierre - I spotted same in some of mine. @zdz2101 can we get this one removed please from the CI checks?
Will try and review this PR tomorrow.
@rossfarrugia @Pierre-Wallet Yea I'll look into it but I think it might be related to the Check / (release/devel/oldrel) and supposed to go away once those resolve, but I'll check again
28 Updated documentation with metadata tag
28 added tests for Head circumference metadata
28 Capitalised bmi in the documentation
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiralpeds (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()