pharmaverse / admiralpeds

Admiral Package Extension for Pediatric Clinical Trials
https://pharmaverse.github.io/admiralpeds/
Apache License 2.0
13 stars 3 forks source link

closes #28 Updated all WHO metadata #29

Closed Pierre-Wallet closed 7 months ago

Pierre-Wallet commented 7 months ago

28 Updated documentation with metadata tag

28 added tests for Head circumference metadata

28 Capitalised bmi in the documentation

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

Pierre-Wallet commented 7 months ago

@rossfarrugia , all updates done! It was eventually not a minor update :)

Pierre-Wallet commented 7 months ago

@rossfarrugia , could you please explain me what this "Check Expected — Waiting for status to be reported" means and what action is expected from my side? Thanks!

rossfarrugia commented 7 months ago

@rossfarrugia , could you please explain me what this "Check Expected — Waiting for status to be reported" means and what action is expected from my side? Thanks!

Ignore this one Pierre - I spotted same in some of mine. @zdz2101 can we get this one removed please from the CI checks?

Will try and review this PR tomorrow.

zdz2101 commented 7 months ago

@rossfarrugia @Pierre-Wallet Yea I'll look into it but I think it might be related to the Check / (release/devel/oldrel) and supposed to go away once those resolve, but I'll check again