pharmaverse / admiralpeds

Admiral Package Extension for Pediatric Clinical Trials
https://pharmaverse.github.io/admiralpeds/
Apache License 2.0
13 stars 3 forks source link

Closes #34 function for growth parameters for height/length #45

Closed zdz2101 closed 3 months ago

zdz2101 commented 4 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 4 months ago

Code Coverage

Package Line Rate Health
admiralpeds 71%
Summary 71% (88 / 124)
Minlei0201 commented 3 months ago

Hi @zdz2101 , I've added a few comments on the PR (on the derive_params_growth_height.R). Feel free to take a look and let me know if you have any follow-up questions!