Closed bundfussr closed 1 month ago
thanks Stefan!
@Fanny-Gautier please can you consider these comments and make updates in a new branch/PR if you agree
Unit tests are now failing since keeping potential extra variables: I have to re-work on it. Will try to complete them by tomorrow.
Background Information
The final dataset shouldn't be assigned to a variable. Then the returned dataset is printed. At the moment we get:
Then also the example in the documentation could be simplified to
derive_*()
functions shouldn't drop any variables or records.by_vars
isNULL
? I wonder if the check should be replaced by callingsignal_duplicate_records(dataset, by_vars = exprs(!!!by_vars, AGE))
regardless of the value ofby_vars
.dataset
argumentAGEU
is listed as required variable. However, this isn't checked nor is the variable used in the code.Definition of Done
No response