Closes #73 improve derive_interp_records

[Fanny-Gautier]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• [x] Place Closes # into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• [x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• [x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• [x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• [x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• [x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• [x] Address any updates needed for vignettes and/or templates
• [x] Update NEWS.md under the header # admiralpeds (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• [x] Build admiralpeds site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
• [x] Address or fix all lintr warnings and errors - lintr::lint_package()
• [x] Run R CMD check locally and address all errors and warnings - devtools::check()
• [x] Link the issue in the Development Section on the right hand side.
• [x] Address all merge conflicts and resolve appropriately
• [x] Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions[bot]]

Package	Line Rate	Health
admiralpeds	78%	➖
Summary	78% (153 / 195)	➖

[Fanny-Gautier]

@bundfussr , Could you please suggest how to get ride of the following error ? Thanks.

When I run lintr in my session I don't get any error.

It's well added in admiralpeds-package.R, and NAMESPACE and Imported in DESCRIPTION

[rossfarrugia]

@Fanny-Gautier as per discussion on the other PR please also make any vignette updates as a result of these template changes so both remain consistent in the same PR for ease of review, and you'll need to merge latest main branch (resolving any conflicts)

[Fanny-Gautier]

@bundfussr , Could you please suggest how to get ride of the following error ? Thanks.

When I run lintr in my session I don't get any error.

It's well added in admiralpeds-package.R, and NAMESPACE and Imported in DESCRIPTION

Hi @rossfarrugia , could you please suggest how to fixe this error that I can finish this PR and assign the reviewers? thanks

[rossfarrugia]

@bundfuss i need your advice for the above please. i tried a few things as you can see in the commits above and don't get why lintr fails here. R CMD check is fine so what Fanny has added seems fine to me.

@Fanny-Gautier in the meantime feel free to add reviewers and mark as ready as it looks to me like an error on the CI side not with anything you've done. We use the same function in admiralroche in same way as how you've added and our gitlab CI doesn't ever have a problem.

[bundfussr]

@bundfuss i need your advice for the above please. i tried a few things as you can see in the commits above and don't get why lintr fails here. R CMD check is fine so what Fanny has added seems fine to me.

@rossfarrugia , yes, that's very strange. Could we clear the cache and rerun the workflow? Unfortunately, I don't have the rights to clear the cache.

[rossfarrugia]

@rossfarrugia , yes, that's very strange. Could we clear the cache and rerun the workflow? Unfortunately, I don't have the rights to clear the cache.

no luck unfortunately - i've asked Dinakar's team if any ideas

[Fanny-Gautier]

🎉🎉 Thanks @bundfussr for the solution and update !! Good to know that the dependencies must be defined !

[Fanny-Gautier]

Due to system issue (login fails due to worldwide Microsoft issue), I haven't been able to progress much on the new comments. Hoping it's working again on Monday.

[Fanny-Gautier]

Having system issue again, I raised a Ticket to my IT support... @bundfussr could you please review what I have already committed today and let me know whether this is good enough ? Thanks