pharmaverse / admiralpeds

Admiral Package Extension for Pediatric Clinical Trials
https://pharmaverse.github.io/admiralpeds/
Apache License 2.0
13 stars 3 forks source link

Closes #40 use pharmaversesdtm to host dm_peds and vs_peds #84

Closed zdz2101 closed 1 month ago

zdz2101 commented 3 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

github-actions[bot] commented 3 months ago

Code Coverage

Package Line Rate Health
admiralpeds 99%
Summary 99% (267 / 271)
zdz2101 commented 3 months ago

Shouldn't actually be necessary to merge and close this but to demo the migration assuming the goes through this is done

zdz2101 commented 2 months ago

@Fanny-Gautier @rossfarrugia made the appropriate updates that use the :: convention that was in the admiral discussion

rossfarrugia commented 1 month ago

@zdz2101 we should add something to NEWS file in this PR. I think Fanny is busy with project work so if you want to merge https://github.com/pharmaverse/pharmaversesdtm/pull/115, and then we can get this one merged too and ticked off the list.

Fanny-Gautier commented 1 month ago

@zdz2101 we should add something to NEWS file in this PR. I think Fanny is busy with project work so if you want to merge pharmaverse/pharmaversesdtm#115, and then we can get this one merged too and ticked off the list.

Sorry for not having followed much these last few days. I am currently over busy with Study work and the R-Pharma workshop preparation. Please do not hesitate to ping me in Slack for any request which require my attention... I'll add them on my to do list. In the mean time, I'l add this PR review on my list for tomorrow ;-) Thanks

rossfarrugia commented 1 month ago

Great - thanks @Fanny-Gautier ! @zdz2101 when you get chance are you ok to merge and do a quick test run of main now that {pharmaversesdtm} is updated too. Then the final step would be making an issue for adsl_peds and advs_peds in {pharmaverseadam}.