search

pharmaverse / admiralpeds

Admiral Package Extension for Pediatric Clinical Trials
https://pharmaverse.github.io/admiralpeds/
Apache License 2.0
13 stars 3 forks source link

Restrict computation of CHG and PCHG to post-baseline records only #95

Open Fanny-Gautier opened 1 month ago

Fanny-Gautier commented 1 month ago

Background Information

CHG and PCHG computation have been updated in templates and vignettes of {admiral} in order to compute them only for post- baseline records. This is what is usually expected for these 2 parameters. A note has also been added to notify that this computation rule is left to the producer choice. See issue #2484 and it's corresponding PR

Definition of Done

Procced with the same in {admiralpeds} template and vignette: Use restrict_derivation() while deriving CHG and PCHG and add a note explaining the rational of this update.

rossfarrugia commented 1 month ago

@remikk this is a good issue for you to help with. you can follow similar to what was done for admiral core package as linked above. let me and Fanny know if any issue

remikk commented 1 month ago

@Fanny-Gautier @rossfarrugia Sure, thank you for the assignment. I will take care of the issue.

rossfarrugia commented 1 month ago

thanks @remikk - you can tag us both as reviewers once the PR is ready