Closes #156 blog post admiral future package extensions

Fanny-Gautier commented 2 months ago

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[x] Place Closes # into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
[x] Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
[x] Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, add your own tag! We occasionally tidy up all tags for consistency.
[x] Add a short description for your blog post in the description field at the top of the markdown document.
[x] Blog post is short, personalized, reproducible and readable
[x] Add a disclaimer at the top of your post, if appropriate (example: Disclaimer This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
[x] Address all merge conflicts and resolve appropriately
[x] Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

Fanny-Gautier commented 2 months ago

After resolving a conflict with WORDLIST, I am getting the following CICD check failing: Could you please suggest how to resolve it ?

bms63 commented 2 months ago

Fix the spelling - couple of words were missing

Can anything with file names and {} brackets be replaced with something else or just removed? I nervous that will do some damage down the road

The image is not rendering.

I don't think GSK did anything. We can get dropped out of this post...sadly 😭

Fanny-Gautier commented 2 months ago

@bms63 , Thank you for your comments that we have implemented. The PR is now ready for final review. Thank you.

Fanny-Gautier commented 2 months ago

Could you please give me some tips about how to resolve it ? I ran CICD from my end and all tests are passed. I do not understand from below error what is wrong. Thanks.

bms63 commented 2 months ago

There is a commented out section of the CICD.R for spelling for adding the words. Are you running that part? It is my only trick! :)

Fanny-Gautier commented 2 months ago

There is a commented out section of the CICD.R for spelling for adding the words. Are you running that part? It is my only trick! :)

bms63 commented 2 months ago

Very strange! It is all good - I can fix it before we release. @StefanThoma any tips?

Fanny-Gautier commented 1 month ago

Very strange! It is all good - I can fix it before we release. @StefanThoma any tips?

Any updates regarding this issue as we also face it on #171 ? Thanks

StefanThoma commented 1 month ago

Very strange! It is all good - I can fix it before we release. @StefanThoma any tips?

Any updates regarding this issue as we also face it on #171 ? Thanks

I run the spellcheck locally using the CICD script in the R/ folder and it gave me some words to update and one typo. Now it passes the spellcheck. I replaced one link with a shorter version to not trigger the spellcheck.

Fanny-Gautier commented 1 month ago

I run the spellcheck locally using the CICD script in the R/ folder and it gave me some words to update and one typo. Now it passes the spellcheck. I replaced one link with a shorter version to not trigger the spellcheck.

Any idea why when I run it locally from my end I cannot see the mismatches ? I only get "No spelling errors found".

StefanThoma commented 1 month ago

I run the spellcheck locally using the CICD script in the R/ folder and it gave me some words to update and one typo. Now it passes the spellcheck. I replaced one link with a shorter version to not trigger the spellcheck.

Any idea why when I run it locally from my end I cannot see the mismatches ? I only get "No spelling errors found".

I really don't quite know why. Which version of spelling are you using? I use: 2.2.1

Whereas the blog rendering uses 2.3 I think. It looks like the message from the CICD run on GH is not very good though.

Lina2689 commented 1 month ago

I really don't quite know why. Which version of spelling are you using? I use: 2.2.1

Thanks @StefanThoma , It's working well with version 2.2.1

manciniedoardo commented 1 month ago

Can we look to approve and release this week?

pharmaverse / blog

Closes #156 blog post admiral future package extensions #171