pharmaverse / blog

Blogging on the latest, greatest and most spectacular stuff happening around the pharmaverse
https://pharmaverse.github.io/blog/
Apache License 2.0
21 stars 9 forks source link

Closes #180 blog post unix vs sas datetime #192

Closed cpiraux closed 1 month ago

cpiraux commented 2 months ago

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

bms63 commented 2 months ago

I think we just need to get rid of this message from dplyr (@StefanThoma I think this is from session update you did, any thoughts??) image

After that I think we are good to go! @manciniedoardo any last thoughts?

bms63 commented 2 months ago

oh and we need to fix the spelling workflow

cpiraux commented 1 month ago

Thanks, everyone, for your review!

I've implemented all the comments. I’ve just updated a paragraph on datasetJSON, as v1.1 is still a draft, by adding a reference to the specification for the latest updates.

One of the checks is still failing. Do you know what to do to make this check pass?

bms63 commented 1 month ago

umm..im not sure what is going on with the spelling check. we can let it slide

bms63 commented 1 month ago

i got spelling to work again! yay!