pharmaverse / blog

Blogging on the latest, greatest and most spectacular stuff happening around the pharmaverse
https://pharmaverse.github.io/blog/
Apache License 2.0
23 stars 11 forks source link

Closes #196 Check post tags using CICD #208

Closed manciniedoardo closed 3 months ago

manciniedoardo commented 3 months ago

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

manciniedoardo commented 3 months ago

@bms63 @StefanThoma @gigikenneth

I've got something super basic working in this PR. Infact the check flags an issue that we had not noticed (posts tagged as "Submissions" vs "Submission"). I think it can be enhanced and improved before merging in. Some ideas:

What do you think?

bms63 commented 3 months ago

Dang...this is awesome! Can it say which tag is culprit?

image

manciniedoardo commented 3 months ago

@StefanThoma @bms63 @gigikenneth

I gave it another pass following your review - let me know your thoughts now. I created an allowed list of tags script and stored them in there, but I'm wondering now whether that is even a good idea as we mention the allowed list of tags:

Also the CICD error message throws a weird code, not sure what that's about: image

Once we are happy with this PR, i can retroactively change the tags on the "Submission" posts and then merge in.

bms63 commented 3 months ago

Now you just have to first the failing CI :)