pharmaverse / blog

Blogging on the latest, greatest and most spectacular stuff happening around the pharmaverse
https://pharmaverse.github.io/blog/
Apache License 2.0
23 stars 11 forks source link

Closes #195: HPC vs reproducibility post #232

Closed AleKoure closed 1 month ago

AleKoure commented 1 month ago

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

AleKoure commented 1 month ago

Thanks for the updates! I've left one other comment about defining demons.

On a broader note, I didn't notice any mention of the pharmaverse or any pharmaverse packages. As this is the pharmaverseblog I am wondering if you could please adapt your post slightly for a pharmaverse-minded audience? E.g.: How is this discussion relevant to:

  • pharmaverse packages
  • The E2E clinical data flow in R

Thanks in advance.

@manciniedoardo Good points! I added some amendments.

As @StefanThoma also suggested:

manciniedoardo commented 1 month ago

Thanks @AleKoure for your updates! for me we can go ahead and merge if conflicts are resolved and @StefanThoma is happy.

manciniedoardo commented 1 month ago

@AleKoure could you please fix the failing style check?

AleKoure commented 1 month ago

I agree. I'll fix ASAP šŸ™‚

On Fri, Oct 11, 2024, 3:34 PM Edoardo Mancini @.***> wrote:

@AleKoure https://github.com/AleKoure could you please fix the failing style check?

ā€” Reply to this email directly, view it on GitHub https://github.com/pharmaverse/blog/pull/232#issuecomment-2407320794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOUXY2QEPJFZ7FZVBMKPVLZ27AT3AVCNFSM6AAAAABOQ3H4RCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGMZDANZZGQ . You are receiving this because you were mentioned.Message ID: @.***>

AleKoure commented 1 month ago

@AleKoure could you please fix the failing style check?

I have resolved the checks and after @shikokuchuo's suggestion, I included a minor update for mirai version 1.3.0. Additionally, I added my affiliation.

manciniedoardo commented 1 month ago

@AleKoure if you fix the final failing link we can go ahead and merge