Closed AleKoure closed 1 month ago
Thanks for the updates! I've left one other comment about defining demons.
On a broader note, I didn't notice any mention of the pharmaverse or any pharmaverse packages. As this is the pharmaverseblog I am wondering if you could please adapt your post slightly for a pharmaverse-minded audience? E.g.: How is this discussion relevant to:
- pharmaverse packages
- The E2E clinical data flow in R
Thanks in advance.
@manciniedoardo Good points! I added some amendments.
As @StefanThoma also suggested:
We use the Pharmavese package logrx
to show some complexities in workflow execution.
We add some additional clarity to the drug efficacy simulation
Thanks @AleKoure for your updates! for me we can go ahead and merge if conflicts are resolved and @StefanThoma is happy.
@AleKoure could you please fix the failing style check?
I agree. I'll fix ASAP š
On Fri, Oct 11, 2024, 3:34 PM Edoardo Mancini @.***> wrote:
@AleKoure https://github.com/AleKoure could you please fix the failing style check?
ā Reply to this email directly, view it on GitHub https://github.com/pharmaverse/blog/pull/232#issuecomment-2407320794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOUXY2QEPJFZ7FZVBMKPVLZ27AT3AVCNFSM6AAAAABOQ3H4RCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGMZDANZZGQ . You are receiving this because you were mentioned.Message ID: @.***>
@AleKoure could you please fix the failing style check?
I have resolved the checks and after @shikokuchuo's suggestion, I included a minor update for mirai
version 1.3.0. Additionally, I added my affiliation.
@AleKoure if you fix the final failing link we can go ahead and merge
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task."posts/zzz_DO_NOT_EDIT_<your post title>"
. This is so that the post date can be auto-updated upon the merge intomain
.CICD.R
line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)
or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical")
for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltags
for consistency.description
field at the top of the markdown document.