Closed pawelru closed 1 month ago
Hmmm... It looks like the R/CICD.R
does not complain but apparently CICD itself does. Do we use something else?
@pawelru we are having some issues with the spellcheck action, please ignore if all fine on your end.
Hello reviewers! Hope you are doing well! I wanted to follow up on this PR to see if you might have a chance to review it. Please let me know if there's anything I can do to help!
Hi Pawel,
Thanks for the nudge, I’ll take a look tomorrow👍
On Wed, 9 Oct 2024 at 19:03, Pawel Rucki @.***> wrote:
Hello reviewers! Hope you are doing well! I wanted to follow up on this PR to see if you might have a chance to review it. Please let me know if there's anything I can do to help!
— Reply to this email directly, view it on GitHub https://github.com/pharmaverse/blog/pull/241#issuecomment-2402852687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUWWEVK4JMXIQKKG4Y7Y6LZ2VOVVAVCNFSM6AAAAABPKFLP3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBSHA2TENRYG4 . You are receiving this because you were mentioned.Message ID: @.***>
Thanks all the good comments! Asking for another round of review 🕺
CICD spell check worked on my side, I've added some words.
LGTM!
@pawelru all merged - please feel free to publicise your post as you see fit and we will re-share 😄
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task."posts/zzz_DO_NOT_EDIT_<your post title>"
. This is so that the post date can be auto-updated upon the merge intomain
.CICD.R
line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)
or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical")
for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltags
for consistency.description
field at the top of the markdown document.