207 new figure figure 3

[huanlugwu]

Pull Request

• Closes #207

[huanlugwu]

Hi @huanlugwu,

Thanks for working on this! Could you look into using the ggsurvfit package instead of survminer for the plot generation? There is a survfit2() function and a ggsurvfit() function that should be analogous to survminer::surv_fit() and survminer::ggsurvplot(), respectively. Since we are pivoting towards using cards/cardx/gtsummary more throughout the package, ggsurvfit should be easier than survminer to use alongside these packages in terms of syntax, input types, workflows, etc.

Thanks!!

Thanks for your review, Emily! I've updated my codes using pharmaverse::{ggsurvfit}, Could you please take another look?

[github-actions[bot]]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
fda-fig_03	👶		$+1.93$	$+8$	$+4$	$0$	$0$

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | fda-fig_03 | 👶 | | $+0.71$ | Figure_03_generation_works_with_custom_values | | fda-fig_03 | 👶 | | $+0.59$ | Figure_03_generation_works_with_default_values | | fda-fig_03 | 👶 | | $+0.55$ | Figure_03_generation_works_with_ggtheme_argument_specified | | fda-fig_03 | 👶 | | $+0.08$ | Figure_03_generation_works_with_no_table |

Results for commit 11514677c51c5eb72ee94e9a97b9a0296fef461a

♻️ This comment has been updated with latest results.

[github-actions[bot]]

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/fda-fig_01.R         75       0  100.00%
R/fda-fig_02.R         75       0  100.00%
R/fda-fig_03.R        107       0  100.00%
R/fda-fig_14.R        115       0  100.00%
R/fda-table_02.R      166       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R       61       0  100.00%
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R      329       0  100.00%
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       42       0  100.00%
R/fda-table_12.R       40       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_22.R       77       0  100.00%
R/fda-table_32.R       94       0  100.00%
R/fda-table_33.R       95       0  100.00%
R/fda-table_34.R       41       0  100.00%
R/fda-table_35.R       23       0  100.00%
R/fda-table_36.R       30       0  100.00%
R/fda-table_38.R       39       0  100.00%
R/utils.R              28       0  100.00%
TOTAL                2042       0  100.00%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  --------
R/fda-fig_03.R     +107       0  +100.00%
TOTAL              +107       0  +100.00%

Results for commit: 87cf4aa5809a12bf9b25365e29ee72531f4fa75b

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

[github-actions[bot]]

Unit Tests Summary

  1 files   30 suites   1m 10s :stopwatch: 134 tests 134 :white_check_mark:   0 :zzz: 0 :x: 480 runs  354 :white_check_mark: 126 :zzz: 0 :x:

Results for commit 87cf4aa5.

:recycle: This comment has been updated with latest results.