pharmaverse / cardinal

FDA Safety Tables and Figures
https://pharmaverse.github.io/cardinal/
Other
42 stars 6 forks source link

Add missing table 36 screenshot #236

Closed edelarua closed 2 months ago

edelarua commented 3 months ago

Pull Request

Closes #233

github-actions[bot] commented 3 months ago

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/fda-fig_01.R         75       0  100.00%
R/fda-fig_02.R         75       0  100.00%
R/fda-fig_14.R        115       0  100.00%
R/fda-table_02.R      166       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R       61       0  100.00%
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R      329       0  100.00%
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       42       0  100.00%
R/fda-table_12.R       40       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_22.R       77       0  100.00%
R/fda-table_32.R       94       0  100.00%
R/fda-table_33.R       95       0  100.00%
R/fda-table_34.R       41       0  100.00%
R/fda-table_35.R       23       0  100.00%
R/fda-table_36.R       30       0  100.00%
R/fda-table_38.R       39       0  100.00%
R/utils.R              28       0  100.00%
TOTAL                1935       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ff2de836a85fbe926d8ffb76d69cb6a4ab30571f

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 3 months ago

Unit Tests Summary

  1 files   29 suites   1m 12s :stopwatch: 130 tests 130 :white_check_mark:   0 :zzz: 0 :x: 472 runs  350 :white_check_mark: 122 :zzz: 0 :x:

Results for commit ff2de836.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
fda-table_09 💔 $8.13$ $+1.10$ $0$ $0$ $0$ $0$

Results for commit 01bc983fdc2354bb125c391424e1675dd052b835

♻️ This comment has been updated with latest results.

edelarua commented 2 months ago

Hi Emily, thanks for adding the screenshot! I have rendered the page locally and found that the "Function Details" tab of the page is not displayed correctly:

Hi @jknizia,

Thanks for the review! I went through all of the templates and fixed the tables (https://github.com/pharmaverse/cardinal/pull/236/commits/ef5ffa15a2c316045eca2fa5518e15f363ca6f51) so this shouldn't occur anywhere on the site now :)

jknizia commented 2 months ago

Hi Emily, thanks for adding the screenshot! I have rendered the page locally and found that the "Function Details" tab of the page is not displayed correctly:

Hi @jknizia,

Thanks for the review! I went through all of the templates and fixed the tables (ef5ffa1) so this shouldn't occur anywhere on the site now :)

Great, thank you!