pharmaverse / examples

End to end examples of pharmaverse packages for common safety clinical reporting analyses
https://pharmaverse.github.io/examples/
Apache License 2.0
6 stars 6 forks source link

Closes #32: Comparison between `logr` and `logrx` #62

Closed DavidBlairs closed 4 months ago

DavidBlairs commented 5 months ago

Pull Request

Howdy. I've written up a document explaining the differences between the logr and logrx packages. Let me know if you have any feedback and I'll make adjustments.

bms63 commented 5 months ago

David!! This is so cool!! I will give more thorough review tomorrow.

@pharmaverse/examples We don't endorse logr in the pharmaverse. Do we want to specify this or endorse the package? Unsure if this happened already?? It comes from the https://r-sassy.org/ folks.

The Novo Nordisk folks are trying to open source their logging package as well. They gave me a preview of it and WOW, very cool! It would be nice to add this on down the rode.

rossfarrugia commented 5 months ago

@pharmaverse/examples We don't endorse logr in the pharmaverse. Do we want to specify this or endorse the package? Unsure if this happened already?? It comes from the https://r-sassy.org/ folks.

@bms63 No, I think it's fine that the blog talks of a recommended pharmaverse package vs another offering from CRAN, i.e. both don't need to be on pharmaverse. Whenever I've heard r-sassy discussed in any pharmaverse WGs the feeling has usually been that for pharmaverse most prefer to appreciate R for R, as in not trying to replicate SAS here.

The Novo Nordisk folks are trying to open source their logging package as well. They gave me a preview of it and WOW, very cool! It would be nice to add this on down the rode.

@NNaikp when's this happening?? šŸ˜

bms63 commented 5 months ago

@dbosak01 would like to get your opinion!! @DavidBlairs is doing comparison between logr and logrx. Probably pull in NN logging package as well. All the logs together!!

dbosak01 commented 5 months ago

Overall accurate. Only part I'd like to change:

States this: "In logr, you manually specify all of the output to be included in the log."

Change to: "In logr, the user has control over what gets or does not get logged. The user can specify which variables, objects, or datasets to send to the log. If the 'autolog' feature is activated, output from dplyr and sassy functions are logged automatically."

bms63 commented 5 months ago

Thanks @dbosak01!!

DavidBlairs commented 5 months ago

Overall accurate. Only part I'd like to change:

States this: "In logr, you manually specify all of the output to be included in the log."

Change to: "In logr, the user has control over what gets or does not get logged. The user can specify which variables, objects, or datasets to send to the log. If the 'autolog' feature is activated, output from dplyr and sassy functions are logged automatically."

Sounds good šŸ‘

bms63 commented 4 months ago

@pharmaverse/examples can we publish this?

bms63 commented 4 months ago

Thanks @DavidBlairs this is awesome addition!!