pharmaverse / ggsurvfit

http://www.danieldsjoberg.com/ggsurvfit/
Other
67 stars 19 forks source link

Export `grid.draw()` methods allowing use of `ggsave()` #110

Closed ddsjoberg closed 1 year ago

ddsjoberg commented 1 year ago

What changes are proposed in this pull request?

If there is an GitHub issue associated with this pull request, please provide link. closes #107


Reviewer Checklist (if item does not apply, mark is as complete)

When the branch is ready to be merged into master:

bailliem commented 1 year ago

This could be an issue with my work machine, but might need to update the renv snapshot to include ggeasy. My windows install is throwing an error when building the site as the ggeasy package is missing. It dosen't look like the package is part of the renv lock file . I don't see where its being used. Its resolved once I install the package.

-- RMarkdown error -------------------------------------------------------------
Quitting from lines 202-211 (gallery.Rmd) 
Error in loadNamespace(x) : there is no package called 'ggeasy'
In addition: Warning messages:
1: Tried to calculate with group_by(), but the calculation failed.
Falling back to ungrouped filter operation... 
2: Using `across()` in `filter()` is deprecated, use `if_any()` or `if_all()`. 
--------------------------------------------------------------------------------
Error in render_rmarkdown(pkg, input = input, output = output_file, output_format = format,  : 
  Failed to render RMarkdown
Caused by error:
! callr subprocess failed: there is no package called 'ggeasy'
Caused by error:
! there is no package called 'ggeasy'
Error: callr subprocess failed: Failed to render RMarkdown
Caused by error:
! callr subprocess failed: there is no package called 'ggeasy'
Caused by error:
! there is no package called 'ggeasy'
Type .Last.error.trace to see where the error occurred
ddsjoberg commented 1 year ago

Hey @bailliem ! Thank you for the review!